-
Notifications
You must be signed in to change notification settings - Fork 315
KFLUINFRA-2666: macos values in host-config chart #9489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KFLUINFRA-2666: macos values in host-config chart #9489
Conversation
… into staging host-values' host-values.
🤖 Gemini AI Assistant AvailableHi @meyrevived! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @meyrevived, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
/retest |
components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml
Show resolved
Hide resolved
hugares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to regenerate the kueue configuration running this script: ./hack/kueue-vm-quotas/generate-queue-config.sh
components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml
Outdated
Show resolved
Hide resolved
components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml
Outdated
Show resolved
Hide resolved
components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml
Show resolved
Hide resolved
Co-authored-by: Hugo Arès <[email protected]>
Signed-off-by: Hugo Ares <[email protected]>
Done |
|
for review purpose, here are the relevant snippets from host-config for stage-p01: |
components/multi-platform-controller/base/host-config-chart/templates/host-config.yaml
Outdated
Show resolved
Hide resolved
…mplates/host-config.yaml
hugares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/retest |
|
/lgtm |
|
@meyrevived: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
manish-jangra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, manish-jangra, meyrevived The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@meyrevived: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add macos host config values in host-config chart and into staging host-values' host-values.